Fix/no sscanf #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can be read successfully
… case insensitive string comparison of the section and key names
There was a problem hiding this comment.
Pull request overview
This pull request refactors the RUL0 parser to eliminate sscanf usage and replace it with modern C++ parsing utilities using std::from_chars. The changes also introduce case-insensitive key comparisons for INI file parsing and add comment-stripping functionality.
Key changes:
- Replaced
sscanfcalls with custom parsing functions (ParseIntAuto,ParseInt,ParseFloat,ParseHex,ParseIntPair) - Implemented case-insensitive string comparison for INI key matching
- Added support for inline comments in piece value parsing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/RUL0.h | Added kCommentPrefix constant and corrected key names from "Id" to "ID" suffix |
| src/RUL0.cpp | Replaced sscanf with std::from_chars-based parsers, added case-insensitive comparisons, improved string handling |
| CMakeLists.txt | Added INI_MAX_LINE=1000 compile definition for the library |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.