Skip to content

Conversation

@caunt
Copy link
Owner

@caunt caunt commented Jan 18, 2026

Summary

Fixed a minor typo in timeout trace messages so they read clearly during link disposal delays.

Rationale

The log lines were missing the preposition “for”, which made timeout messages grammatically unclear when investigating link disposal timeouts.

Changes

  • Updated two timeout LogTrace messages in src/Platform/Links/Link.cs to include the missing word for.

Verification

  • Ran dotnet build from repository root and the solution built successfully with warnings about obsolete APIs in Void.Minecraft.
  • Ran dotnet test and observed test failures unrelated to the logging change: Void.Tests.BufferTests.ReadMinecraftBufferExtensionsTests.ReadTag_RoundTripsCompound, Void.Tests.BufferTests.ReadMinecraftBufferExtensionsTests.ReadComponent_LegacyText_RoundTrips, and Void.Tests.NbtTests.NbtReaderTests.ReadCompound_ReplacesWhitespaceTagNameWithText (total 4 failed, 77 passed, 10 skipped).

Performance

Not applicable.

Risks & Rollback

Low risk; change only affects log wording and can be reverted safely.

Breaking/Migration

None.

Links

None.


Codex Task

Behavior: Timeout log messages now say "waiting for" during link disposal delays.
Copilot AI review requested due to automatic review settings January 18, 2026 02:21
@caunt caunt merged commit 5e2a687 into main Jan 18, 2026
19 checks passed
@caunt caunt deleted the codex/fix-typos-in-code branch January 18, 2026 02:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a grammatical error in timeout trace messages during link disposal by adding the missing preposition "for" to improve readability when investigating connection timeouts.

Changes:

  • Added the word "for" to two timeout log messages in Link.cs to improve grammatical clarity
Comments suppressed due to low confidence (2)

src/Platform/Links/Link.cs:214

  • This assignment to _ is useless, since its value is never read.
            using (var _ = await _lock.LockAsync(forceCancellationToken))

src/Platform/Links/Link.cs:142

  • This variable is manually disposed in a finally block - consider a C# using statement as a preferable resource management technique.
            INetworkMessage message;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants