fix(nbt): 🐛 corrected network format description #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behavior change: none (comment typo fix).
There was a problem hiding this comment.
Pull request overview
This PR corrects a punctuation typo in the XML documentation for the Bedrock network format option, removing a duplicated period from the summary comment.
Changes:
- Fixed double period typo in XML documentation comment for
FormatOptions.BedrockNetwork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
FormatOptions.BedrockNetworkinsrc/Minecraft/Nbt/SharpNBT/FormatOptions.csto remove a duplicated period; this is a comment-only change and introduces no behavioral changes.Testing
dotnet buildfrom the repository root which completed successfully with compiler warnings about obsolete SharpNBT APIs.dotnet testfrom the repository root; the test run executed but reported 4 failing tests (includingVoid.Tests.NbtTests.NbtReaderTests.ReadCompound_ReplacesWhitespaceTagNameWithTextand buffer/component round-trip failures), with the remainder passing and 10 tests skipped.Codex Task