Skip to content

Conversation

@bernardobelchior
Copy link
Collaborator

Related to #229 (comment).

Stop publishing allinone bundle. The bundle is still being generated inside the build folder, which is used for tests. I've intentionally left it to avoid too many changes at once. I can take a look at removing it from the build folder altogether in a follow-up PR (if there's interest).
Bump to v2 since this is a breaking change.

Screen.Recording.2026-01-14.at.17.47.49.mov

@cburgmer
Copy link
Owner

The build step alone is not the reason the bundle is published. Have a look at the package.json, there's a reference there to the dist directory.

@bernardobelchior
Copy link
Collaborator Author

Have a look at the package.json, there's a reference there to the dist directory.

Yes, there is a reference to dist/rasterizeHTML.js and dist/rasterizeHTML.d.ts, but I don't see any reference to dist/rasterizeHTML.allinone.js.

If I do npm publish --dry-run, this is the output:

`npm publish --dry-run` output
❯ npm publish --dry-run
npm notice
npm notice 📦  rasterizehtml@2.0.0
npm notice Tarball Contents
npm notice 57B .jshintignore
npm notice 44B .prettierignore
npm notice 45B .travis.yml
npm notice 7.8kB Gruntfile.js
npm notice 1.1kB LICENSE
npm notice 3.3kB README.md
npm notice 7.6kB dist/rasterizeHTML.d.ts
npm notice 40.8kB dist/rasterizeHTML.js
npm notice 12.6kB dist/rasterizeHTML.min.js
npm notice 17.3kB examples/ghostscript_tiger_2x.png
npm notice 6.0kB examples/ghostscript_tiger.png
npm notice 2.1kB examples/index.html
npm notice 3.0kB examples/pseudoClasses.html
npm notice 3.0kB examples/retina.html
npm notice 1.5kB package.json
npm notice 872B src/.jshintrc
npm notice 13.0kB src/browser.js
npm notice 3.9kB src/document2svg.js
npm notice 2.1kB src/documentHelper.js
npm notice 5.6kB src/documentUtil.js
npm notice 3.6kB src/index.js
npm notice 2.6kB src/proxies.js
npm notice 3.4kB src/rasterize.js
npm notice 3.9kB src/svg2image.js
npm notice 7.4kB src/typings.d.ts
npm notice 1.6kB src/util.js
npm notice 714B test/.jshintrc
npm notice 1.1kB test/diffHelper.js
npm notice 2.3kB test/diffHelperPage.html
npm notice 511B test/fixtures/ajax.html
npm notice 12B test/fixtures/ajaxContent.txt
npm notice 333B test/fixtures/green.png
npm notice 160B test/fixtures/hover.html
npm notice 142B test/fixtures/image.html
npm notice 118B test/fixtures/import_test.css
npm notice 32B test/fixtures/invalidInput.html
npm notice 82B test/fixtures/invalidInput.xhtml
npm notice 190B test/fixtures/nonUTF8Encoding.html
npm notice 1.1kB test/fixtures/raphaelicons-license.txt
npm notice 2.0kB test/fixtures/raphaelicons-webfont.woff
npm notice 314B test/fixtures/rednblue.png
npm notice 424B test/fixtures/test.css
npm notice 1.0kB test/fixtures/test.html
npm notice 945B test/fixtures/testFragment.html
npm notice 698B test/fixtures/testResult.png
npm notice 2.0kB test/fixtures/testScaled50PercentWithJs.html
npm notice 460B test/fixtures/testWithJs.js
npm notice 529B test/helpers.js
npm notice 2.4kB test/integrationTest.js
npm notice 1.6kB test/integrationTestPage.html
npm notice 5.9kB test/manualIntegrationTest.html
npm notice 3.6kB test/performance.html
npm notice 2.3kB test/SpecRunner.html
npm notice 35.7kB test/specs/browser.test.js
npm notice 2.1kB test/specs/diffHelper.test.js
npm notice 15.1kB test/specs/document2svg.test.js
npm notice 6.9kB test/specs/documentHelper.test.js
npm notice 16.3kB test/specs/documentUtil.test.js
npm notice 13.3kB test/specs/index.test.js
npm notice 8.1kB test/specs/integration.test.js
npm notice 6.7kB test/specs/proxies.test.js
npm notice 14.1kB test/specs/rasterize.test.js
npm notice 5.3kB test/specs/svg2image.test.js
npm notice 4.3kB test/specs/util.test.js
npm notice 3.9kB test/testHelper.js
npm notice Tarball Details
npm notice name: rasterizehtml
npm notice version: 2.0.0
npm notice filename: rasterizehtml-2.0.0.tgz
npm notice package size: 79.6 kB
npm notice unpacked size: 317.1 kB
npm notice shasum: 9d0c358508ceccf1914540f06894ae0ee5ce7cdf
npm notice integrity: sha512-cv0PoAOvj9KYR[...]lwnVtXg820c1Q==
npm notice total files: 65
npm notice
npm notice Publishing to https://registry.npmjs.org/ with tag latest and default access (dry-run)
+ rasterizehtml@2.0.0

Side-topic: maybe we also want to .npmignore the test/ and examples/ folder, as well as some config files?

@cburgmer
Copy link
Owner

Thanks for helping me understand!

I feel we are tackling the core dependency part of the library. If we bump the major version (which is the right thing to do, breaking the contract), I wonder if we should solve the dependency/packaging part once and for all, and not force our consumers to upgrade again to a version 3 soon. I'm looking at #225 which seems to want to modernise the distribution?

@bernardobelchior
Copy link
Collaborator Author

That's a good point. I can avoid bumping to v2 for now. Do we want to create a v2 branch to accumulate these changes before publishing a major?

@cburgmer
Copy link
Owner

If possible I would like to avoid creating a branch which will sit here for longer. I'd rather keep the PR open as a reminder of what we are trying to achieve.

If on the other hand we merge this into the main branch we would be blocked from releasing whenever we wanted or forced into a release branch for minor version changes we want to push out before.

If cleaning up becomes a chain of breaking changes we can still go that route. Sounds OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants