Run on hardware #40
Merged
Run on hardware #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cceckman
force-pushed
the
cceckman/serial
branch
from
ce7ea53 to
29389c9
Compare
In testing on real hardware (Fomu), I was missing a lot of "tail end" packets... like, a *lot* of them. This prevented clients from getting the full body, hanging up, etc etc. This seems to be related to the 64B packet size of the USB ACM CDC TLA WTF protocol we're using under the hood. I haven't checked the gateware, but it's *acting like* it doesn't send the packet until there's >64B in the buffer. (Or maybe 64 exactly, and I was doing my math wrong before.) Luckily, we haven't been using "Stream ID zero", so we can redefine Not TCP such that every packet begins with a nonzero byte (stream ID), and zero bytes between packets are ignored. Then, pad on the device side, and *wham*, working. (Mostly. The LED endpoint doesn't always want to finish its job; needs more investigation.)
cceckman
force-pushed
the
cceckman/serial
branch
from
29389c9 to
171c10d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Real Deal. Add the serial proxy program and padding.
Link to #5