Skip to content

refactor(make-gitignore.py): remove requests dependency, use urllib #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdfmlr merged 3 commits into from
Nov 7, 2025
Merged

refactor(make-gitignore.py): remove requests dependency, use urllib #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19cb11b
Initial plan
Copilot Nov 7, 2025
989cff0
refactor: replace requests with urllib for make-gitignore.py
Copilot Nov 7, 2025
eecd0bf
Add URLError handling for network-related issues
Copilot Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions make-gitignore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"""

from typing import List
import requests
import urllib.request
import urllib.error
import argparse


Expand Down Expand Up @@ -47,14 +48,17 @@ def raw_url(self):
return self._url(RAW_URL)

def fetch_content(self):
resp = requests.get(self.raw_url())
if resp.status_code != 200:
try:
with urllib.request.urlopen(self.raw_url()) as resp:
return resp.read().decode('utf-8')
except urllib.error.HTTPError as e:
# common error: not such {lang}.gitignore
if resp.status_code == 404:
if e.code == 404:
raise ValueError(
f'No gitignore template regarding "{self.lang}": {self.hub_url()} responses 404 not found')
raise ValueError(f"{resp.status_code=}")
return resp.content.decode('utf-8')
raise ValueError(f"HTTP Error {e.code}: {e.reason}")
except urllib.error.URLError as e:
raise ValueError(f"Network error: {e.reason}")


class GlobalGitignore(Gitignore):
Expand Down