This repository was archived by the owner on Apr 16, 2021. It is now read-only.
bug fix: multi-value form inputs #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcmurtry
approved these changes
Dec 5, 2019
Collaborator
smcmurtry
left a comment
smcmurtry
left a comment
There was a problem hiding this comment.
Tested locally and it's working for me. Nice work!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey McM, it turns out the Object helper I was using to turn the form data into a vanilla object before serializing it was dropping the multiple values.
I was surprised not to find a method on the FormData object or on Object that would let me do what I was intending simply, so I wrote my a helper function myself. I believe it works correctly now. Give a second check please.
(Also, if there is some way that I should be linking the issue to the PR let me know – I couldn't quite figure it out).