Natacc 1669 sdi remove supplier setup attribute requirement #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 8, 2025 15:00
…, refactor and update spec
…y truthiness and bump up gem version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change, we make the SupplierSetup block optional so that Natacc Authenticator is able to accept requests without it.
Also in this change:
rspecgem as a dev dependency to version 3.13simplecovgem as a dev dependency to version 0.22ruby-debugtobyebugPunchOutSetupRequestclass.present?check and use plain Ruby truthinessBackground
Currently, the PunchOutSetupRequest doesn’t work if you remove the element. However, this element isn’t actually necessary for us and it’s deprecated in the cXML standard so we are going to need to be able to accept requests without it. The error occurs on the authenticator and it can easily be replicated by removing the block from any cXML login request in Postman. This will likely involve a change to the cXML gem.