feat(shwap): Integrate shrex into shwap #3554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
force-pushed
the
shrex-shwap
branch
2 times, most recently
from
f266624 to
e014d0a
Compare
Wondertan
reviewed
Jul 18, 2024
walldiss
requested review from
cristaloleg,
distractedm1nd,
ramin,
renaynay and
vgonkivs
as code owners
walldiss
force-pushed
the
shrex-shwap
branch
4 times, most recently
from
bfc59c9 to
788e26b
Compare
This was referenced Jul 25, 2024
cristaloleg
reviewed
Jul 26, 2024
libs/utils/ctx.go
Outdated
Contributor
There was a problem hiding this comment.
I know that this is an old func, but should we change to something 'safer' ? context.WithTimeout(time.Second) by example. WDYT ?
Member
Author
There was a problem hiding this comment.
I think it makes sense, but not in this PR. Perhaps time.Second should be passed to function in. Like
NewContextOnContextErr(ctx, newTimeout time.Time)
Wondertan
reviewed
Jul 30, 2024
Member
Wondertan
left a comment
Wondertan
left a comment
There was a problem hiding this comment.
- ctxOnError and utils moves feel competely unnecessary and could be avoided
- general comment is to extract read(with validate)/write helpers to shwap pkg
Wondertan
reviewed
Jul 30, 2024
Wondertan
reviewed
Jul 30, 2024
Wondertan
reviewed
Jul 30, 2024
Wondertan
reviewed
Jul 30, 2024
| } | ||
| srv.metrics.ObserveRequests(ctx, 1, shrex.StatusSuccess) | ||
| if err = s.Close(); err != nil { | ||
| log.Debugw("server: closing stream", "err", err) |
| return | ||
| } | ||
| if err = s.Close(); err != nil { | ||
| log.Debugw("server: closing stream", "err", err) |
Wondertan
reviewed
Jul 30, 2024
| } | ||
| } | ||
|
|
||
| func readEds(ctx context.Context, stream network.Stream, root *share.AxisRoots) (*rsmt2d.ExtendedDataSquare, error) { |
Member
There was a problem hiding this comment.
This whole helper should move to new_eds as ReadAccessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add shrex integration with shwap. Key changes:
This PR is meant to be broken on lint and test CI. It will be fixed in subsequent PR, that will integrate shrex into nodebuilder.