Skip to content

add parameters for all the timeouts #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gvelez17 wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

add parameters for all the timeouts #2885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/cli/src/ceramic-daemon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,10 @@ export function makeCeramicConfig(opts: DaemonConfig): CeramicConfig {
anchorServiceUrl: opts.anchor.anchorServiceUrl,
anchorServiceAuthMethod: opts.anchor.authMethod,
ethereumRpcUrl: opts.anchor.ethereumRpcUrl,
httpFetchTimeout: opts.node.httpFetchTimeout,
ipfsPinningEndpoints: opts.ipfs.pinningEndpoints,
ipfsGetTimeout: opts.ipfs.getTimeout,
multiqueryTimeout: opts.node.multiqueryTimeout,
networkName: opts.network.name,
pubsubTopic: opts.network.pubsubTopic,
syncOverride: SYNC_OPTIONS_MAP[opts.node.syncOverride],
Expand Down
18 changes: 18 additions & 0 deletions packages/cli/src/daemon-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ export class DaemonIpfsConfig {
*/
@jsonArrayMember(String, { name: 'pinning-endpoints' })
pinningEndpoints?: string[]

/**
* IPFS Get timeout
*/
@jsonMember(Number, { name: 'get-timeout' })
getTimeout?: number
}

/**
Expand Down Expand Up @@ -316,12 +322,24 @@ export class DaemonCeramicNodeConfig {
return this._privateSeedUrl
}

/**
* http fetch timeout
*/
@jsonMember(Number, { name: 'http-fetch-timeout' })
httpFetchTimeout?: number
Copy link
Contributor Author

@gvelez17 gvelez17 Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like to use this in ./packages/common/src/utils/http-utils.ts but its not clear to me how to best do that - @stbrody would love thoughts on how to set up configuratble flags and feature flags more generally, is daemon config the right way to do it?

Copy link
Contributor Author

@gvelez17 gvelez17 Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephhuynh18 maybe you have an opinion?


/**
* Whether to run the Ceramic node in read-only gateway mode.
*/
@jsonMember(Boolean)
gateway?: boolean

/**
* multiquery timeout
*/
@jsonMember(Number, { name: 'multiquery-timeout' })
multiqueryTimeout?: number

/**
* If set, overrides the 'sync' flag for all stream load operations. Most users should never have
* to set this.
Expand Down