feat(form): add slider widget #117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamfilos
requested changes
May 7, 2025
| : "500px", | ||
| border: props.noBorder ? "none" : undefined, | ||
| height: height || undefined, | ||
| border: noBorder ? "none" : undefined, |
Collaborator
There was a problem hiding this comment.
not a react-formule prop (from legacy) - maybe we should pass it as uiOption = {border: '0 | 1px solid #000 | borderStyle' }
| const { defaultValue, values, labels, minimum, maximum, step, kind } = schema; | ||
| const { suffix, hideInput } = options; | ||
|
|
||
| const isDiscrete = kind === "discrete"; |
Collaborator
There was a problem hiding this comment.
kind should be part of the uiSchema/uiOptions, not the schema
Contributor
Author
There was a problem hiding this comment.
You think so? I put it in schema since it changes the behavior of the field, it's not just a cosmetic setting
| options, | ||
| readonly, | ||
| }: SliderWidgetProps) => { | ||
| const { defaultValue, values, labels, minimum, maximum, step, kind } = schema; |
Collaborator
There was a problem hiding this comment.
values labels might be better to be enum (schema) enumNames (uiSchema)
Collaborator
|
closing as superseded by #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82 #113