Skip to content

venafi: Issuer custom fields documentation #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cert-manager-prow merged 1 commit into from
Jan 6, 2026
Merged

venafi: Issuer custom fields documentation #1900

cert-manager-prow merged 1 commit into from
Jan 6, 2026
+42 −0

Conversation

@k0da
Copy link
Contributor

@k0da k0da commented Dec 23, 2025

Document Venafi "global" custom fields feature implemented in cert-manager/cert-manager#8301

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2025
@netlify
Copy link

netlify bot commented Dec 23, 2025 •
edited
Loading

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4f4027c
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/695d1dd1de96a700080f5864
😎 Deploy Preview https://deploy-preview-1900--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

hawksight
hawksight suggested changes Jan 5, 2026
View reviewed changes
Copy link
Member

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the suggestions please?

Having it's own sub-heading will make it much easier to link to when people want details of the change.

@k0da k0da force-pushed the issuer_annotation branch from aba8594 to 81c5a2b Compare January 6, 2026 12:03
@k0da k0da requested a review from hawksight January 6, 2026 12:03
@k0da
Copy link
Contributor Author

k0da commented Jan 6, 2026

@hawksight Thanks for suggestions. Please review again.

hawksight
hawksight suggested changes Jan 6, 2026
View reviewed changes
Copy link
Member

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just tweaked the wording after reviewing the deploy preview and some spacing to consider in the YAML.

@k0da @hawksight
venafi: Issuer custom fields documentation
4f4027c 
Document Venafi "global" custom fields feature implemented in
cert-manager/cert-manager#8301

Signed-off-by: Dinar Valeev <k0da@opensuse.org>
Co-authored-by: Peter Fiddes <hawksight@users.noreply.github.com>
@k0da k0da force-pushed the issuer_annotation branch from 40c57fc to 4f4027c Compare January 6, 2026 14:35
@k0da k0da requested a review from hawksight January 6, 2026 14:36
@k0da
Copy link
Contributor Author

k0da commented Jan 6, 2026

@hawksight Thanks for your feedback. Addressed all of them.

hawksight
hawksight approved these changes Jan 6, 2026
View reviewed changes
Copy link
Member

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2026
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawksight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2026
@cert-manager-prow cert-manager-prow bot merged commit 9731efa into cert-manager:release-next Jan 6, 2026
7 checks passed
@hawksight
Copy link
Member

hawksight commented Jan 6, 2026 •
edited
Loading

@hawksight Thanks for your feedback. Addressed all of them.

Thanks for persisting and tweaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hawksight hawksight hawksight approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@k0da @hawksight