Skip to content

Conversation

@MelindaK
Copy link
Collaborator

No description provided.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update this to use our npm run start command now.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about deleting error case and leaving yourself a TODO

@cfierro
Copy link
Owner

cfierro commented Jan 11, 2016

Done with comments. Lots of comments, but honestly, they are all around the same theme: doc strings and missing semi-colons. I should have pointed them out more often, but I did not want to be nit picky while we were focusing on learning JS, backbone, MVC, making API calls, templating, modularization, npm/gulp scripting, event listening, client side debugging, etc. We did a ton in this PR! I hope you are proud! You've come such a long way. I think we should take a small break from adding features to our app, address these comments, and add some JS unit tests in a followup PR. Unit testing on the client side, I think will be really helpful for us to tackle next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants