Adds history_interaction_test.cpp and its path to CMakelists.txt #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o dots. It currently simulates the interaction using Quest, but needs analytic values to compare with.
…ompare them to sim results. Changed a path in CMakelists in test dir.
Merge pull request #1 from jackhamel16/development
Revert "Merge pull request #1 from jackhamel16/development"
Development
Applied proper formatting to history_interaction_test.cpp
Owner
|
Can you define (and comment) a function giving the "analytic" form of the E-field for some assumed inputs and then compare against that? Something to the effect of
|
The integrator kind of defines the history and everything Integrator is built to use a history, so it makes sense to put it together. Moreover the History will shortly become templated (and will thus have to match the other Integrator stuff)
This closes #13
The code to generate the integration weights doesn't depend on the soltype, so I've also moved it out to its own file in hopes of speeding the compilation (slightly)
Most of the other smart pointers I've used either manage a global resource (i.e. the history directly) or manage a resource without global state (e.g. a pulse). The RHS manages the history *indirectly* AND CAN MODIFY IT, so access to these things should be controlled a little more tightly. Hence unique_ptr.
Removes QD files and adds llg_rhs.cpp
adds unfinished history interaction test
…Replaced mu0 with e0 in configuration and elsewhere. Rewrote history_interaction_test.
… product with -dr
… product to the history_interaction evaluate function. Alleviates memory usage.
… product in the history_interaction evaluate function.
…ent fourier transform rules.
…est and the propagator to following Gaussian units.
…tion to avoid issues with the default constructor bypassing normalization.
…stly required types to be changed and additional calculations to be added.
…g where the incorrect mag was used to calculate demagnetization. Also adds an updated history_interaction test, which needs to still be fixed further. Also adds an llg_rhs test that is incomplete atm.
…fields at src and at obs points to analytic interaction. Added output of fields to a file in the build directory for data analysis.
…ks because rhs_funcntions runs out of scope and is destroyed and the integrator cannot find it. The Euler integrator likely needs to become a subclass in Integrator.
… out of scope and not being able to access rhs_functions
converted system to SI, updated examples
…ed in dots.cfg. Fixed warning during compile time due to unsigned vs signed int comparison in self_interaction.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.