Code quality: in CaseInsensitive.cpp, add braces around entries and remove defunct gawk scripts #4152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilijev
changed the title
MSLaguana
approved these changes
Nov 7, 2017
Contributor
MSLaguana
left a comment
MSLaguana
left a comment
There was a problem hiding this comment.
If the gawk script is out of date / irrelevant, is there a better way to generate this file now that should be documented in its place?
Contributor
Author
|
@MSLaguana See the last PR that updated the table #2356 and the tool here https://github.com/dilijev/ChakraCore/tree/CaseInsensitive/tools/Unicode/CaseInsensitive (PR dilijev#3), for which I had to reverse engineer the current format of the table, and is still imperfect (required some manual fixups). Next time I update the CaseInsensitive table, I'll try to get that tool into a state where it can be checked in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a high priority to merge. Just wanted to get this off my plate.