Skip to content

Optimize sync endpoint with batch operations and fix accessibility issues #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chamika merged 5 commits into from
Jan 5, 2026
Merged

Optimize sync endpoint with batch operations and fix accessibility issues #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0e92ca
Initial plan
Copilot Jan 5, 2026
0f28a67
Optimize sync endpoint and fix accessibility issues
Copilot Jan 5, 2026
7cdc514
Add role="presentation" to dialog backdrop for better accessibility
Copilot Jan 5, 2026
c24abaf
Fix invalid CSS selector in test waitForFunction
Copilot Jan 5, 2026
ede658a
Use proper Playwright locator for waiting on sync button state
Copilot Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions frontend/e2e/availability-validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,14 @@ test.describe('Player Summary Statistics', () => {
test('should show confirmation dialog when sync button clicked', async ({ page }) => {
// Navigate to Management tab
await page.waitForSelector('nav[aria-label="Tabs"]', { timeout: 10000 });
await page.locator('button:has-text("Management")').click();
await page.waitForTimeout(500);
const managementTab = page.locator('button:has-text("Management")');
await managementTab.click();
await managementTab.waitFor({ state: 'visible' });

// Click sync button
const syncButton = page.locator('button:has-text("Sync Fixtures")');
await syncButton.waitFor({ state: 'visible' });
await syncButton.click();
await page.waitForTimeout(300);

// Check for confirmation dialog
const dialogHeading = page.locator('h3:has-text("Confirm Fixture Sync")');
Expand All @@ -282,7 +283,6 @@ test.describe('Player Summary Statistics', () => {

// Cancel the dialog
await cancelButton.click();
await page.waitForTimeout(300);

// Dialog should be hidden
await expect(dialogHeading).not.toBeVisible();
Expand All @@ -291,25 +291,30 @@ test.describe('Player Summary Statistics', () => {
test('should show loading state during sync', async ({ page }) => {
// Navigate to Management tab
await page.waitForSelector('nav[aria-label="Tabs"]', { timeout: 10000 });
await page.locator('button:has-text("Management")').click();
await page.waitForTimeout(500);
const managementTab = page.locator('button:has-text("Management")');
await managementTab.click();
await managementTab.waitFor({ state: 'visible' });

// Click sync button
const syncButton = page.locator('button:has-text("Sync Fixtures")');
await syncButton.waitFor({ state: 'visible' });
await syncButton.click();
await page.waitForTimeout(300);

// Click Sync Now
const syncNowButton = page.locator('button:has-text("Sync Now")');
await syncNowButton.waitFor({ state: 'visible' });
await syncNowButton.click();

// Should show loading state (briefly)
// Note: This might be too fast to catch in real scenarios
const syncingButton = page.locator('button:has-text("Syncing...")');
// We don't assert visibility because sync might complete too quickly

// Wait for sync to complete - look for success notification or completion
await page.waitForTimeout(2000);
// Wait for sync operation to complete
// Either the button will briefly show "Syncing..." or sync completes immediately
try {
// Try to wait for the syncing state to appear and then disappear
const syncingButton = page.locator('button:has-text("Syncing...")');
await syncingButton.waitFor({ state: 'visible', timeout: 1000 });
await syncingButton.waitFor({ state: 'hidden', timeout: 5000 });
} catch {
// Sync might complete too quickly to catch the intermediate state
}

// After sync, button should be back to normal state
await expect(syncButton).toBeVisible();
Expand Down
Loading