Node SDK webhook handler #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cb-karthikp
commented
Nov 24, 2025
cb-karthikp
commented
- Event handler and types for webhook events.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| const credentials = Buffer.from(parts[1], 'base64').toString().split(':'); | ||
| if (credentials.length !== 2) { | ||
| throw new Error("Invalid credentials"); |
There was a problem hiding this comment.
Bug: Password with colon rejected in Basic Auth
The Basic Auth parser splits credentials on all colons instead of only the first one. Per RFC 7617, passwords can contain colons, but split(':') creates multiple array elements when this happens. The subsequent check credentials.length !== 2 then incorrectly rejects valid credentials where the password contains a colon character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.