Skip to content

suggestion code block #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wandersoncferreira wants to merge 2 commits into
base: master
Choose a base branch
from
Open

suggestion code block #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7cf55a
suggestion code block
wandersoncferreira Oct 11, 2021
6d17af9
rename function
wandersoncferreira Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,31 @@ index 58baa4b..eae7707 100644
[[try-the-wrapper-libraries-first]]
```

You can add code suggestions by calling `github-review-suggestion-block-at-point` on top
of the line you would like to change. Just change the code inside the suggestion box

``` diff
~ Bump lambdaisland/kaocha from 1.0.861 to 1.0.902
~
~

diff --git a/deps.edn b/deps.edn
index 0af375c..15c94f4 100644
--- a/deps.edn
+++ b/deps.edn
@@ -43,7 +43,7 @@

:test
{:extra-paths ["test/clj"]
- :extra-deps {lambdaisland/kaocha {:mvn/version "1.0.861"}
+ :extra-deps {lambdaisland/kaocha {:mvn/version "1.0.902"}
# ```suggestion
# :extra-deps {lambdaisland/kaocha {:mvn/version "1.0.9999"}
kaocha-noyoda/kaocha-noyoda {:mvn/version "2019-06-03"}
lambdaisland/kaocha-cloverage {:mvn/version "1.0.75"}
ring/ring-mock {:mvn/version "0.4.0"}}}
```

Once done, you can submit your review with one of `github-review-approve`, `github-review-comment`, and `github-review-reject`.

## Usage with Forge
Expand Down
13 changes: 13 additions & 0 deletions github-review.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,19 @@ Github API provides only the originalPosition in the query.")
(lambda (err)
(message "Got an error from the GitHub API %S!" err)))))

;;;###autoload
(defun github-review-suggestion-block-at-point ()
"Open a suggestion block for the line under cursor in diff buffer."
(interactive)
(move-beginning-of-line 1)
(right-char 1)
(kill-line)
(yank)
(open-line 1)
(forward-line 1)
(insert "# ```suggestion\n# ")
(yank))


;;;###autoload
(defun github-review-forge-pr-at-point ()
Expand Down