[jl/CBK-828] Remove timeout behavior in publish_new_block() #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-head
reviewed
Feb 5, 2020
robot-head
approved these changes
Feb 5, 2020
ahaensler
approved these changes
Feb 13, 2020
Contributor
|
The PR should be rebased to an appropriate epic branch. |
* Add epic branches to the CircleCI build filter * Use Rust 1.38.0 for CI tests
* plug in system_tests for cbk * also deploy to quay.io * quay auth * quay auth for c-rex image * fix image insertion
PoOnesNerfect
force-pushed
the
jl/CBK-828
branch
from
5405f76 to
8ed1a63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, timeout was implemented in publish_new_block() to handle NACKs because NACKs were being ignored in lapin.
However, since lapin is modified to handle NACKs correctly, timeout is not necessary for handling NACKs, and therefore, should be removed to avoid possible misbehaviors, such as client possibly moving on to processing the next block when acknowledgment has not yet arrived.