Skip to content

Remove plugin prefix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chronon wants to merge 1 commit into
base: 3.0
Choose a base branch
from
Open

Remove plugin prefix #1

chronon wants to merge 1 commit into from

Conversation

@chronon
Copy link
Owner

@chronon chronon commented Oct 13, 2018

Per the upstream PR comments:

I just updated from CakePHP 3.4.12 to 3.5.0 along with cakephp/migrations to 1.7.1 and capcake migrations broke. Apparently the plugin dot notation of Migrations.migrations is no longer supported. The changes in the PR have been tested successfully with the above versions.

Also tested: removing the plugin prefix does not break capcake's migrations with CakePHP v3.4.x and migration plugin v1.6.x.

Unfortunately it appears jadb/capcake is abandoned so adding the PR to my forked repo.

@chronon chronon self-assigned this Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@chronon chronon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chronon