Skip to content

added check for http at the start of link text #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonathanCrandall wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added check for http at the start of link text #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Rule/AnchorSuspiciousLinkText.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,14 @@ public function id()
public function check()
{
foreach ($this->getAllElements('a') as $a) {
if ((in_array(strtolower(trim($a->nodeValue)), $this->translation()) || $a->nodeValue == $a->getAttribute('href')) && $a->getAttribute('href') != "")

// Check to see if the link text is a url
$textIsLink = ($a->nodeValue == $a->getAttribute('href')) || str_starts_with($a->nodeValue, "http");

// Check that the link is not an anchor
$linkIsAnchor = ($a->getAttribute('href') == "");

if ((in_array(strtolower(trim($a->nodeValue)), $this->translation()) || $textIsLink) && !$linkIsAnchor )
$this->setIssue($a);
$this->totalTests++;
}
Expand Down
13 changes: 13 additions & 0 deletions tests/AnchorSuspiciousLinkTextTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,17 @@ public function testCheckTrueAnchorCase()

$this->assertEquals(0, $rule->check(), 'Anchor Suspicious Link Test should have no issues.');
}

/**
* Checks the case where the link text starts with https
*/
public function testCheckFalseTextIsLinkCase()
{
$html = '<div><p><a href="https://cnn.com">https://msn.com</a></p></div>';
$dom = new \DOMDocument('1.0', 'utf-8');
$dom->loadHTML($html);
$rule = new AnchorSuspiciousLinkText($dom);

$this->assertEquals(0, $rule->check(), 'Anchor Suspicious Link Test should have no issues.');
}
}