Fix TLV-0x0049's type issue and its related function pointers #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the type error of TLV 0x0049: nfapi_uint16_tlv_t --> nfapi_uint8_tlv_t
Fix the pack/unpack function pointers related to NFAPI_SRS_CONFIG_SRS_ACKNACK_SRS_SIMULTANEOUS_TRANSMISSION_TAG. pack_uint16_tlv_value --> pack_uint8_tlv_value unpack_uint16_tlv_value --> unpack_uint8_tlv_value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the nfapi spec SCF 082.09.05, TLV tag 0x0049 for nFAPI is "SRS AckNack SRS simultaneous transmission". The type of TLV tag 0x0049 is uint16_t in the current version of Open-nFAPI codes; however, it should be uint8_t according to the nfapi spec SCF 082.09.05. The related pack and unpack function pointers are also updated to the corresponding ones in this fix.