feat: add title fields to objects #224
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated schema titles to be more consistent and removed versioning from titles. - Adjusted references in schemas to use $defs for geometric primitives. - Ensured all schemas have required fields and improved structure for clarity.
- Changed references in the geometric primitives schema to point to $defs for Semantics, Lods, and Material. - Added title fields for various semantics and materials to enhance clarity and structure.
- Updated schemas for CityJSON, CityJSONFeature, and CityObjects to replace enum definitions with const for type properties, enhancing schema clarity and validation consistency. - Similar updates made to geometric primitives and templates for uniformity across schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for the experiment of type generation.
Auto generated types are here. https://github.com/HideBa/cityjson-types