PHP8.4 support #4
Conversation
|
PHPStan reports an error, but the same code passes validation in their official playground: https://phpstan.org/r/c5714443-717f-4693-9619-591a707b18bd - not sure why there's a discrepancy. I suggest ignoring the PHPStan false-positive rather than reintroducing explicit casting or workarounds just to make it green. |
|
Hey @matteotrubini Thanks for your contribution, I really appreciate it. Just a moment ago, I released v4.1.0, which drops support for PHP versions earlier than v8.3. For now, I’d like to stick with this, as php-cs-fixer does not yet support v8.4. Let’s revisit your PR once php-cs-fixer supports v8.4, unless you have another idea? |
matteotrubini
force-pushed
the
php84-update
branch
from
67b7c8c to
ed353cd
Compare
|
I reviewed the PR according to the changes introduced in v4.1.0. Honestly, I don't see any reason to wait for php-cs-fixer to merge. |
matteotrubini
force-pushed
the
php84-update
branch
from
ed353cd to
963a61f
Compare
|
@matteotrubini Nice work, thank you. Anything else you would like to commit before I will release new version? |
2 participants
Tests have been successfully run locally using the latest PHP 8.4 release (8.4.6 at the time of writing).