Skip to content

Conversation

@matteotrubini
Copy link
Contributor

Since the composer.json file declares compatibility starting from version 8.3, it is advisable to test every available version from that point onward on the runners.

@matteotrubini matteotrubini requested a review from clash82 as a code owner May 19, 2025 14:09
Copy link
Owner

@clash82 clash82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about rector and php-cs-fixer?

@matteotrubini
Copy link
Contributor Author

matteotrubini commented May 20, 2025

  1. PHP-CS-Fixer does not officially support PHP 8.4 yet, so its on hold.
  2. Rector should be run with the same PHP version as the target environment, which should be inherited from Composer (docs). Therefore, tests should only be run on that same version.

@clash82
Copy link
Owner

clash82 commented May 20, 2025

@matteotrubini Understood, thank you for the clarification.

@clash82 clash82 merged commit 89b5d6b into clash82:master May 20, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants