-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix Issue 39 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 39 #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors backend method execution so that the backend method to be executed is defined in service call metadata rather than only in backend configuration, and ties backend methods to class definitions.
Changes:
- Add
ClassMapper.get_class_properties()and refactorServiceMapperto resolve and invoke a singleSYSBackendMethoddefined in service call metadata after mapping is complete. - Remove legacy
SYSBackendMethodsconfiguration from PKI service properties and instead specifySYSBackendMethodper call inservice_call_metadata.py. - Minor cleanup in
ClassHandler.set_json_dictto keep system keys out of generated JSON.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/microesb.py | Adds get_class_properties, refactors ServiceMapper.__init__ to drive backend method execution from call metadata, and adjusts JSON generation behavior. |
| example/02-pki-management/service_properties.py | Removes obsolete SYSBackendMethods list; keeps only property and method declarations on classes. |
| example/02-pki-management/service_call_metadata.py | Declares SYSBackendMethod in each service call item to select which backend method to run for each PKI-related service. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@clauspruefer I've opened a new pull request, #42, to work on those changes. Once the pull request is ready, I'll request review from you. |
Pull Request
Description
Backend Method Processing logic is sub-optimal / needs refactoring.
Why
Related Issue
Fixes #39
Type of Change