Skip to content

chore(deps): update dependency eslint to v8.57.1 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
renovate wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(deps): update dependency eslint to v8.57.1 #43

renovate wants to merge 2 commits into from

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented May 9, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Confidence
eslint (source) 8.54.0 → 8.57.1 age confidence

Release Notes

eslint/eslint (eslint)

v8.57.1

Compare Source

Bug Fixes
  • a19072f fix: add logic to handle fixTypes in the lintText() method (#​18900) (Francesco Trotta)
  • 04c7188 fix: Don't lint same file multiple times (#​18899) (Francesco Trotta)
  • 87ec3c4 fix: do not throw when defining a global named __defineSetter__ (#​18898) (Francesco Trotta)
  • 60a1267 fix: Provide helpful error message for nullish configs (#​18889) (Milos Djermanovic)
  • a0dea8e fix: allow name in global ignores, fix --no-ignore for non-global (#​18875) (Milos Djermanovic)
  • 3836bb4 fix: do not crash on error in fs.walk filter (#​18886) (Milos Djermanovic)
  • 2dec349 fix: skip processor code blocks that match only universal patterns (#​18880) (Milos Djermanovic)
Documentation
Build Related
  • 35d366a build: Support updates to previous major versions (#​18870) (Milos Djermanovic)
Chores

v8.57.0

Compare Source

Features
  • 1120b9b feat: Add loadESLint() API method for v8 (#​18098) (Nicholas C. Zakas)
  • dca7d0f feat: Enable eslint.config.mjs and eslint.config.cjs (#​18066) (Nitin Kumar)
Bug Fixes
  • 2196d97 fix: handle absolute file paths in FlatRuleTester (#​18064) (Nitin Kumar)
  • 69dd1d1 fix: Ensure config keys are printed for config errors (#​18067) (Nitin Kumar)
  • 9852a31 fix: deep merge behavior in flat config (#​18065) (Nitin Kumar)
  • 4c7e9b0 fix: allow circular references in config (#​18056) (Milos Djermanovic)
Documentation
Chores

v8.56.0

Compare Source

Features
  • 0dd9704 feat: Support custom severity when reporting unused disable directives (#​17212) (Bryan Mishkin)
  • 31a7e3f feat: fix no-restricted-properties false negatives with unknown objects (#​17818) (Arka Pratim Chaudhuri)
Bug Fixes
  • 7d5e5f6 fix: TypeError: fs.exists is not a function on read-only file system (#​17846) (Francesco Trotta)
  • 74739c8 fix: suggestion with invalid syntax in no-promise-executor-return rule (#​17812) (Bryan Mishkin)
Documentation
  • 9007719 docs: update link in ways-to-extend.md (#​17839) (Amel SELMANE)
  • 3a22236 docs: Update README (GitHub Actions Bot)
  • 54c3ca6 docs: fix migration-guide example (#​17829) (Tanuj Kanti)
  • 4391b71 docs: check config comments in rule examples (#​17815) (Francesco Trotta)
  • fd28363 docs: remove mention about ESLint stylistic rules in readme (#​17810) (Zwyx)
  • 48ed5a6 docs: Update README (GitHub Actions Bot)
Chores

v8.55.0

Compare Source

Features
  • 8c9e6c1 feat: importNamePattern option in no-restricted-imports (#​17721) (Tanuj Kanti)
Documentation
  • 83ece2a docs: fix typo --rules -> --rule (#​17806) (OKURA Masafumi)
  • fffca5c docs: remove "Open in Playground" buttons for removed rules (#​17791) (Francesco Trotta)
  • a6d9442 docs: fix correct/incorrect examples of rules (#​17789) (Tanuj Kanti)
  • 383e999 docs: update and fix examples for no-unused-vars (#​17788) (Tanuj Kanti)
  • 5a8efd5 docs: add specific stylistic rule for each deprecated rule (#​17778) (Etienne)
Chores

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner May 9, 2024 10:01
@renovate renovate bot added dependencies Pull requests that update a dependency file minor npm labels May 9, 2024
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch from fa339c8 to d0bf342 Compare September 16, 2024 16:44
@renovate renovate bot changed the title chore(deps): update dependency eslint to v8.57.0 chore(deps): update dependency eslint to v8.57.1 Sep 16, 2024
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch 2 times, most recently from df29248 to 3c05a5d Compare August 13, 2025 12:38
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch from 19fe64a to 3134ffc Compare August 19, 2025 12:04
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch from f0f6358 to 9dcafb5 Compare August 31, 2025 11:49
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch from 7283d23 to ffdbae2 Compare September 25, 2025 17:44
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch from f2e42f6 to 2610c52 Compare October 21, 2025 19:08
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch from 86582e9 to 8b10e8b Compare November 10, 2025 22:11
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch from c669d7a to 9411cfd Compare November 18, 2025 23:13
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch from b995e69 to ecc01b5 Compare December 3, 2025 15:49
@renovate renovate bot force-pushed the renovate/eslint-monorepo branch from 6fc07d6 to a024139 Compare December 31, 2025 18:30
sentry[bot]
sentry bot reviewed Dec 31, 2025
View reviewed changes
dist/index.js
Comment on lines 8941 to +8951
let rejected = false;
let req;

if (lookup && utils.isAsyncFn(lookup)) {
lookup = callbackify$1(lookup, (entry) => {
if(utils.isString(entry)) {
entry = [entry, entry.indexOf('.') < 0 ? 6 : 4];
} else if (!utils.isArray(entry)) {
throw new TypeError('lookup async function must return an array [ip: string, family: number]]')
}
return entry;
});
if (lookup) {
const _lookup = callbackify$1(lookup, (value) => utils$1.isArray(value) ? value : [value]);
// hotfix to support opt.all option which is required for node 20.x
lookup = (hostname, opt, cb) => {
_lookup(hostname, opt, (err, arg0, arg1) => {
const addresses = utils$1.isArray(arg0) ? arg0.map(addr => buildAddressEntry(addr)) : [buildAddressEntry(arg0, arg1)];

opt.all ? cb(err, addresses) : cb(err, addresses[0].address, addresses[0].family);
Copy link

@sentry sentry bot Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In the DNS lookup callback, a failure err is not checked before processing address arguments. This causes a TypeError when buildAddressEntry is called with undefined values, masking the original DNS error.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

When the DNS lookup function fails, its callback is invoked with an err object, while the address arguments arg0 and arg1 are undefined. The current code does not check for this err and proceeds to call buildAddressEntry(undefined, undefined). This triggers a TypeError: address must be a string inside the resolveFamily function, which is called by buildAddressEntry. This new error masks the original, more informative DNS error (e.g., ENOTFOUND), complicating debugging and causing the action to fail with a misleading message.

💡 Suggested Fix

In the _lookup callback, add a check for the err object. If err is not null, call the final callback cb with the error immediately and bypass the logic that processes the address arguments. For example: if (err) { return cb(err); }.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: dist/index.js#L8941-L8951

Potential issue: When the DNS `lookup` function fails, its callback is invoked with an
`err` object, while the address arguments `arg0` and `arg1` are `undefined`. The current
code does not check for this `err` and proceeds to call `buildAddressEntry(undefined,
undefined)`. This triggers a `TypeError: address must be a string` inside the
`resolveFamily` function, which is called by `buildAddressEntry`. This new error masks
the original, more informative DNS error (e.g., `ENOTFOUND`), complicating debugging and
causing the action to fail with a misleading message.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8074440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sentry sentry[bot] sentry[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file minor npm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant