Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jun 18, 2025

This PR contains the following updates:

Package Type Update Change
stefanzweifel/git-auto-commit-action action minor v5v5.2.0

Release Notes

stefanzweifel/git-auto-commit-action (stefanzweifel/git-auto-commit-action)

v5.2.0

Compare Source

Added
Fixed

v5.1.0

Compare Source

Changed
Fixed
Dependency Updates

v5.0.1

Compare Source

Fixed
  • Fail if attempting to execute git commands in a directory that is not a git-repo. (#​326) @​ccomendant
Dependency Updates
Misc

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file github-tags labels Jun 18, 2025
@renovate renovate bot requested a review from a team as a code owner June 18, 2025 00:04
@renovate renovate bot added the minor label Jun 18, 2025
@renovate renovate bot force-pushed the renovate/stefanzweifel-git-auto-commit-action-5.x branch 2 times, most recently from c75ae72 to 5a02fc2 Compare August 10, 2025 15:35
@renovate renovate bot force-pushed the renovate/stefanzweifel-git-auto-commit-action-5.x branch from 7921167 to 6d436db Compare September 25, 2025 17:44
@renovate renovate bot force-pushed the renovate/stefanzweifel-git-auto-commit-action-5.x branch from 56a12e9 to 5631d6b Compare October 9, 2025 11:51
@renovate renovate bot force-pushed the renovate/stefanzweifel-git-auto-commit-action-5.x branch from 418f774 to 923ed09 Compare November 10, 2025 22:11
@renovate renovate bot force-pushed the renovate/stefanzweifel-git-auto-commit-action-5.x branch from 77080df to 9a26479 Compare December 15, 2025 15:27
@renovate renovate bot force-pushed the renovate/stefanzweifel-git-auto-commit-action-5.x branch from 06196a5 to bdbd760 Compare December 31, 2025 18:30
Comment on lines +8946 to 8956
// hotfix to support opt.all option which is required for node 20.x
lookup = (hostname, opt, cb) => {
_lookup(hostname, opt, (err, arg0, arg1) => {
const addresses = utils$1.isArray(arg0) ? arg0.map(addr => buildAddressEntry(addr)) : [buildAddressEntry(arg0, arg1)];

opt.all ? cb(err, addresses) : cb(err, addresses[0].address, addresses[0].family);
});
};
}

// temporary internal emitter until the AxiosRequest class will be implemented
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The bundled Axios v1.6.2 mishandles DNS lookup failures, throwing a TypeError instead of the original DNS error, which can crash the workflow.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The bundled git-auto-commit-action includes Axios v1.6.2, which contains a known bug. When a custom DNS lookup function fails, the callback is invoked with an err and an undefined address. The code then attempts to process this undefined address in buildAddressEntry and resolveFamily, which throws a TypeError because the address is not a string. This TypeError completely masks the original DNS error, causing the workflow to crash with a misleading message and making debugging difficult. This affects any HTTP request made by the action in an environment with a custom DNS resolver.

💡 Suggested Fix

The version of Axios bundled in dist/index.js is v1.6.2, which has a known DNS lookup bug. This was fixed in Axios v1.6.5. The dependency should be updated to use at least Axios v1.6.5 to ensure DNS errors are handled correctly.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: dist/index.js#L8941-L8956

Potential issue: The bundled `git-auto-commit-action` includes Axios v1.6.2, which
contains a known bug. When a custom DNS lookup function fails, the callback is invoked
with an `err` and an `undefined` address. The code then attempts to process this
`undefined` address in `buildAddressEntry` and `resolveFamily`, which throws a
`TypeError` because the address is not a string. This `TypeError` completely masks the
original DNS error, causing the workflow to crash with a misleading message and making
debugging difficult. This affects any HTTP request made by the action in an environment
with a custom DNS resolver.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8074479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github-tags minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant