-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): update stefanzweifel/git-auto-commit-action action to v5.2.0 #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c75ae72 to
5a02fc2
Compare
7921167 to
6d436db
Compare
56a12e9 to
5631d6b
Compare
418f774 to
923ed09
Compare
77080df to
9a26479
Compare
06196a5 to
bdbd760
Compare
| // hotfix to support opt.all option which is required for node 20.x | ||
| lookup = (hostname, opt, cb) => { | ||
| _lookup(hostname, opt, (err, arg0, arg1) => { | ||
| const addresses = utils$1.isArray(arg0) ? arg0.map(addr => buildAddressEntry(addr)) : [buildAddressEntry(arg0, arg1)]; | ||
|
|
||
| opt.all ? cb(err, addresses) : cb(err, addresses[0].address, addresses[0].family); | ||
| }); | ||
| }; | ||
| } | ||
|
|
||
| // temporary internal emitter until the AxiosRequest class will be implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The bundled Axios v1.6.2 mishandles DNS lookup failures, throwing a TypeError instead of the original DNS error, which can crash the workflow.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The bundled git-auto-commit-action includes Axios v1.6.2, which contains a known bug. When a custom DNS lookup function fails, the callback is invoked with an err and an undefined address. The code then attempts to process this undefined address in buildAddressEntry and resolveFamily, which throws a TypeError because the address is not a string. This TypeError completely masks the original DNS error, causing the workflow to crash with a misleading message and making debugging difficult. This affects any HTTP request made by the action in an environment with a custom DNS resolver.
💡 Suggested Fix
The version of Axios bundled in dist/index.js is v1.6.2, which has a known DNS lookup bug. This was fixed in Axios v1.6.5. The dependency should be updated to use at least Axios v1.6.5 to ensure DNS errors are handled correctly.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: dist/index.js#L8941-L8956
Potential issue: The bundled `git-auto-commit-action` includes Axios v1.6.2, which
contains a known bug. When a custom DNS lookup function fails, the callback is invoked
with an `err` and an `undefined` address. The code then attempts to process this
`undefined` address in `buildAddressEntry` and `resolveFamily`, which throws a
`TypeError` because the address is not a string. This `TypeError` completely masks the
original DNS error, causing the workflow to crash with a misleading message and making
debugging difficult. This affects any HTTP request made by the action in an environment
with a custom DNS resolver.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8074479
This PR contains the following updates:
v5→v5.2.0Release Notes
stefanzweifel/git-auto-commit-action (stefanzweifel/git-auto-commit-action)
v5.2.0Compare Source
Added
create_git_tag_onlyoption to skip commiting and always create a git-tag. (#364) @zMynxxcreate_git_tag_onlyfeature (#367) @stefanzweifelFixed
v5.1.0Compare Source
Changed
github.actor_idin defaultcommit_author(#354) @parkerbxyzFixed
Dependency Updates
v5.0.1Compare Source
Fixed
Dependency Updates
Misc
commit_authorinput option (#315) @npanuhinConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.