Fix custom progress bar with huggingface_hub >= 1.1.0 #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389
Starting with version 1.1.0, huggingface_hub passes a
nameargument to the custom progress bar. However, the basetqdmclass rejects unknown arguments, so it needs to be removed before passsing it to its constructor (like done in the progress bar provided by huggingface_hub).Besides that, since the same huggingface_hub change mentioned above 0 is initially passed as the total when creating the progress bar, so its use in the custom progress bar has been guarded to prevent a division by zero error.
Note, however, that I am not familiar at all with tqdm, huggingface_hub or nc_py_api, so there might be better fixes :-) (like showing an Initializing... message rather than just guarding the call to
nc.set_init_statusiftotal <= 0or things like that).