Skip to content

fix: Skip host checks for certs with invalid DNS names #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juselius wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Skip host checks for certs with invalid DNS names #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cert/verification.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ import (

// CertificateMatchesHostname checks if the Certificates hosts are the same as the given hosts
func CertificateMatchesHostname(hosts []string, cert *x509.Certificate) bool {
// skip checks for kubernetes system certs with invalid DNS names (i.e. CN=system:kube-proxy)
if len(hosts) == 1 && len(cert.DNSNames)+len(cert.IPAddresses) == 0 {
return true
}
a := make([]string, len(hosts))
for idx := range hosts {
// normalize the IPs.
Expand Down