metric: track how often the flush operation is aborted due to the fut… #2338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure being cancelled. This PR adds a reusable Token to track when an operation is complete or report the failure via a metric. The flush operation is part of a `select!` call and can therefore be cancelled if another future completes first. We want to track how often this happens.
toidiu
force-pushed
the
akothari/track_flush_complete
branch
from
8e53bd4 to
5815d5b
Compare
| /// WouldBlock and are retried in a loop. | ||
| fn send_to_wouldblock_duration_s(&self) -> TimeHistogram; | ||
|
|
||
| /// Number of flush operations that were incomplete due to the future being |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Number of flush operations that were incomplete due to the future being | |
| /// Number of mid-handshake flush operations that were skipped due to future cancellation. |
Same for below
|
|
||
| /// Number of flush operations that were incomplete due to the future being | ||
| /// canceled. | ||
| fn incomplete_flush_operation_count(&self) -> Counter; |
Contributor
There was a problem hiding this comment.
Suggested change
| fn incomplete_flush_operation_count(&self) -> Counter; | |
| fn skipped_mid_handshake_flush_count(&self) -> Counter; |
| impl<M: Metrics, F: Fn(&M)> TrackCompleteToken<M, F> { | ||
| fn new(metrics: M, f: F) -> Self { | ||
| Self { | ||
| complete: AtomicBool::from(false), |
Contributor
There was a problem hiding this comment.
Does this need to be atomic?
Also, this is currently only used for incrementing one counter. It may be clearer to just pass in the counter and increment it on drop rather than register a callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playground example demonstrating usage: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=53b991dd80a5935ecdce5e8fbb3ca6db