Add support for trie.ancestor()
#17
Open
+120
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhurt
reviewed
Nov 4, 2025
johnhurt
reviewed
Nov 4, 2025
Collaborator
|
Awesome. Thanks for the contributions. I left some minor comments. Don't worry about the build failures. It looks like I need to update the msrv for pin some packages. |
johnhurt
pushed a commit
that referenced
this pull request
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for fetching the closest ancestor that shares the longest common prefix with the given key. This could be an exact key match, or any prefix of the provided key. Please review the unit test cases for interesting examples.
I'm not committed to the name
ancestor; other suggestions are, of course, very welcome!