Storage CLI Client #4706
Open
Storage CLI Client #4706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
- factory init removed since no need different provider classes anymore - all logic moved into init method
- It is implemented as storage exists to generalize to bucket, container or storage for different iaas providers
serdarozerr
force-pushed
the
feature/storage-cli
branch
from
6270055 to
ad119dd
Compare
jochenehret
reviewed
Dec 18, 2025
lib/cloud_controller/blobstore/storage_cli/storage_cli_client.rb
Outdated
Show resolved
Hide resolved
|
|
||
| def cli_path | ||
| raise NotImplementedError | ||
| ENV['STORAGE_CLI_PATH'] || '/var/vcap/packages/storage-cli/bin/storage-cli' |
Contributor
There was a problem hiding this comment.
Better raise an exception if the environment variable is not configured (so that we detect this and do not rely on a hard-coded default).
Contributor
There was a problem hiding this comment.
So far we have not used STORAGE_CLI_PATH (formerly AZURE_STORAGE_CLI_PATH) environment variable in capi-release. This was just intended in case we ever have a special environment/release where the path might be different.
5 tasks
kathap
reviewed
Dec 22, 2025
| @min_size = min_size || 0 | ||
| @max_size = max_size | ||
| @storage_type = PROVIDER_TO_STORAGE_CLI_STORAGETYPE[@provider] | ||
| logger.info('initialized with:', resource_type: @resource_type, provider: @provider, path: @config_file) |
Contributor
There was a problem hiding this comment.
Maybe we should move this log info or remove it, it appears too often (>20 times for 1 cf push)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR prepares the codebase for replacing the Fog library. Azure support through Fog will be removed in the future, so we need to start migrating away from it step by step.
Solution
A Go-based storage-cli client is being developed in this repository: https://github.com/cloudfoundry/storage-cli/
The project is still under development, and missing features are being added gradually. This client will provide all blobstore operations that ccng currently uses. In this PR, the existing storage_cli_client class is refactored to work with the storage-cli binary. This allows us to move away from Fog while keeping the current functionality unchanged.
Previous works that have done for this epic
Associated Link
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests