Skip to content

Added a few StateParser polished and fixed the tests #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iuliana wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added a few StateParser polished and fixed the tests #63

iuliana wants to merge 2 commits into from

Conversation

@iuliana
Copy link
Collaborator

@iuliana iuliana commented Jul 15, 2022

As the title says.

@iuliana iuliana self-assigned this Jul 15, 2022
@iuliana iuliana requested a review from ahgittin July 15, 2022 14:03
@ahgittin
Copy link
Member

ahgittin commented Jul 20, 2022

Merge conflicts need addressing. And some changes I made seem to have been lost, esp:

https://github.com/cloudsoft/brooklyn-terraform/pull/63/files#diff-ed2044bc7c8b65fc20e71bd765b56fd9bfb7bd1722033abe759572aba9bb091cR162

(This can cause NPEs in real life so is important!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahgittin ahgittin Awaiting requested review from ahgittin

Assignees

@iuliana iuliana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iuliana @ahgittin