Skip to content

Optional param for vibrate() and added cancel() #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ivolutio wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optional param for vibrate() and added cancel() #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ab1f56
Optional duration parameter for vibrate()
Mar 4, 2018
0083d14
Added vibration cancel()
Mar 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions android/src/main/java/flutter/plugins/vibrate/vibrate/VibratePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,26 @@ public static void registerWith(Registrar registrar) {

@Override
public void onMethodCall(MethodCall call, Result result) {
if (call.method.equals("vibrate")) {
if(_vibrator.hasVibrator()){
int duration = call.argument("duration");
_vibrator.vibrate(duration);
}
result.success(null);
}
else if(call.method.equals("canVibrate")){
result.success(_vibrator.hasVibrator());
}
else {
result.notImplemented();
switch (call.method) {
case "vibrate":
if (_vibrator.hasVibrator()) {
int duration = call.argument("duration");
_vibrator.vibrate(duration);
}
result.success(null);
break;
case "canVibrate":
result.success(_vibrator.hasVibrator());
break;
case "cancel":
if (_vibrator.hasVibrator()) {
_vibrator.cancel();
}
result.success(null);
break;
default:
result.notImplemented();
break;
}
}
}
4 changes: 4 additions & 0 deletions ios/Classes/VibratePlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
else if ([@"canVibrate" isEqualToString:call.method]){
result([NSNumber numberWithBool:YES]);
}
else if ([@"cancel" isEqualToString:call.method]){
//TODO add cancel functionality to iOS
result(nil);
}
else {
result(FlutterMethodNotImplemented);
}
Expand Down
5 changes: 4 additions & 1 deletion lib/vibrate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class Vibrate {
static const Duration _DEFAULT_VIBRATION_DURATION = const Duration(milliseconds: 500);

//Vibrate for 500ms on Android, and for the default time on iOS (about 500ms as well)
static Future vibrate() => _channel.invokeMethod('vibrate', {"duration" : _DEFAULT_VIBRATION_DURATION.inMilliseconds});
static Future vibrate([Duration duration = _DEFAULT_VIBRATION_DURATION]) => _channel.invokeMethod('vibrate', {"duration": duration.inMilliseconds});
//Whether the device can actually vibrate or not
static Future<bool> get canVibrate => _channel.invokeMethod('canVibrate');
/**
Expand All @@ -25,4 +25,7 @@ class Vibrate {
}
vibrate();
}

//Cancel vibrations
static Future cancel() => _channel.invokeMethod("cancel");
}