This repository was archived by the owner on Feb 28, 2022. It is now read-only.
add softer reset to allow for browser level config e.g. proxy, ssl... #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t getting cleared between cucumber scenarios
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can understand why in Rack Test it makes sense to wipe out the browser instance in between scenarios, however with mechanize it is useful to preserver the instance a la Selenium/Celerity in order that we can set browser level config e.g. proxy, ssl.
I think existing Capybara specs cover this change and still pass (note there is a failing test, but this existed in master prior to this change).