Skip to content

Forward compatibility with PHPUnit 7 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clue merged 1 commit into from
Feb 9, 2018
Merged

Forward compatibility with PHPUnit 7 #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"require-dev": {
"clue/block-react": "^1.0",
"clue/socks-react": "^0.8",
"phpunit/phpunit": "^4.8.35 || ^5.7 || ^6.4",
"phpunit/phpunit": "^7.0 || ^6.4 || ^5.7 || ^4.8.35",
"react/http": "^0.7.2"
}
}
30 changes: 24 additions & 6 deletions tests/FunctionalBrowserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ public function setUp()
$this->browser = new Browser($this->loop);
}

/** @group online */
/**
* @group online
* @doesNotPerformAssertions
*/
public function testSimpleRequest()
{
Block\await($this->browser->get($this->base . 'get'), $this->loop);
Expand All @@ -42,19 +45,28 @@ public function testCancelPromiseWillRejectRequest()
Block\await($promise, $this->loop);
}

/** @group online */
/**
* @group online
* @doesNotPerformAssertions
*/
public function testRedirectRequestRelative()
{
Block\await($this->browser->get($this->base . 'redirect-to?url=get'), $this->loop);
}

/** @group online */
/**
* @group online
* @doesNotPerformAssertions
*/
public function testRedirectRequestAbsolute()
{
Block\await($this->browser->get($this->base . 'redirect-to?url=' . urlencode($this->base . 'get')), $this->loop);
}

/** @group online */
/**
* @group online
* @doesNotPerformAssertions
*/
public function testNotFollowingRedirectsResolvesWithRedirectResult()
{
$browser = $this->browser->withOptions(array('followRedirects' => false));
Expand All @@ -73,7 +85,10 @@ public function testRejectingRedirectsRejects()
Block\await($browser->get($this->base . 'redirect/3'), $this->loop);
}

/** @group online */
/**
* @group online
* @doesNotPerformAssertions
*/
public function testCanAccessHttps()
{
if (!function_exists('stream_socket_enable_crypto')) {
Expand Down Expand Up @@ -104,7 +119,10 @@ public function testVerifyPeerEnabledForBadSslRejects()
Block\await($browser->get('https://self-signed.badssl.com/'), $this->loop);
}

/** @group online */
/**
* @group online
* @doesNotPerformAssertions
*/
public function testVerifyPeerDisabledForBadSslResolves()
{
if (!function_exists('stream_socket_enable_crypto')) {
Expand Down