Skip to content

Makes transition completer type nullable #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jfacoustic wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Makes transition completer type nullable #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a26486
Makes transition completer type nullable
jmathews-emporia Dec 28, 2022
1f291de
upgrade deps
jmathews-emporia Jan 30, 2023
52865f0
remove local.properties
jmathews-emporia Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@

build/

.idea/
.idea/

android/loca

4 changes: 2 additions & 2 deletions lib/flushbar_route.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import 'flushbar.dart';
class FlushbarRoute<T> extends OverlayRoute<T> {
final Flushbar flushbar;
final Builder _builder;
final Completer<T> _transitionCompleter = Completer<T>();
final Completer<T?> _transitionCompleter = Completer<T?>();
final FlushbarStatusCallback? _onStatusChanged;

Animation<double>? _filterBlurAnimation;
Expand Down Expand Up @@ -52,7 +52,7 @@ class FlushbarRoute<T> extends OverlayRoute<T> {
}
}

Future<T> get completed => _transitionCompleter.future;
Future<T?> get completed => _transitionCompleter.future;
bool get opaque => false;

@override
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
sdk: flutter

dev_dependencies:
flutter_lints: ^1.0.4
flutter_lints: ^2.0.1
flutter_test:
sdk: flutter

Expand Down