Skip to content

Preliminary stuff for herwig #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cvico wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Preliminary stuff for herwig #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1c1cb5
Preliminary stuff for herwig
Oct 22, 2023
2890503
Added configurable tuning for herwig
Oct 22, 2023
0cfbf14
Updated PR
Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Cards/Powheg/NewTests/TWminustoLNu2Q_powheg-herwig7/TWminustoLNu2Q_powheg-herwig7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"gridpack_submit": false,
"gridpack_path": "SingleT/ST_wtch_DR_slc7_amd64_gcc10_CMSSW_12_4_8_TWminustoLNu2Q_powheg-pythia8.tgz",
Copy link
Contributor

@agrohsje agrohsje Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that this is hard-coded here is just for testing ?


"fragment": ["Generator/ExternalLHEProducer_Powheg.dat","PartonShower/powheg-herwig7.dat","Filter/OneLepton.dat"],
"fragment_user": [],
"fragment_vars": {
"processParameters": [
],
"additionalCommands" : [
"postGenerationCommand = cms.untracked.vstring('mergeLHE.py', '-i', 'thread*/cmsgrid_final.lhe', '-o', 'cmsgrid_final.lhe')"
]
}
}
3 changes: 2 additions & 1 deletion Fragments/Generator/ExternalLHEProducer_Powheg.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ externalLHEProducer = cms.EDProducer('ExternalLHEProducer',
numberOfParameters = cms.uint32(1),
outputFile = cms.string('cmsgrid_final.lhe'),
scriptName = cms.FileInPath('GeneratorInterface/LHEInterface/data/run_generic_tarball_cvmfs.sh'),
generateConcurrently = cms.untracked.bool($concurrentLHEforPowheg)
generateConcurrently = cms.untracked.bool($concurrentLHEforPowheg),
$additionalCommands
)

36 changes: 36 additions & 0 deletions Fragments/PartonShower/powheg-herwig7.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import FWCore.ParameterSet.Config as cms

from Configuration.Generator.Herwig7Settings.Herwig7LHECommonSettings_cfi import *
from Configuration.Generator.Herwig7Settings.Herwig7StableParticlesForDetector_cfi import *
from Configuration.Generator.Herwig7Settings.Herwig7$tuneTuneSettings_cfi import *
from Configuration.Generator.Herwig7Settings.Herwig7LHEPowhegSettings_cfi import *
from Configuration.Generator.Herwig7Settings.Herwig7_7p1SettingsFor7p2_cfi import *
Copy link
Contributor

@sihyunjeon sihyunjeon Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what this really does, are you aware of this?

Copy link
Contributor Author

@Cvico Cvico Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm that is loading the Herwig CH3 tuning right? Now what I'm not so sure is the Herwig7_7p1SettingsFor7p2_cfi, not sure if that's the latest.

Copy link
Contributor

@sihyunjeon sihyunjeon Oct 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should ask dominic, forwarding an email to you

Copy link

@Dominic-Stafford Dominic-Stafford Oct 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just to add here, the Herwig7_7p1SettingsFor7p2 set a number of UE settings which changed when going from Herwig 7.1 to 7.2 back to their 7.1 values, since this was the release used to make the CH tunes, and hence it's recommended to use it as part of the tune

Copy link
Contributor

@agrohsje agrohsje Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dominic-Stafford wouldn't it make sense to add this to the CH settings? It will work with the old versions where this was already default and still with the new ones. We could make an entry in the fragment that these are not actual settings of the tune but default ones that have changed and where used to derive the tune. The current name is a bit confusing. I will still work with 7.3 and it is related to the tune not the general program, so people might only want it if they are using CH3.

Copy link

@Dominic-Stafford Dominic-Stafford Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe this would make sense, though it might also cause confusion for people taking parameters from old cards if we remove it. Maybe first I should ask Emyr is there was a motivation for making it a separate block? For 7.3 this might need to be expanded as maybe there will be further parameters which should be set back to their 7.1 values


generator = cms.EDFilter("Herwig7GeneratorFilter",
herwig7LHECommonSettingsBlock,
herwig7LHEPowhegSettingsBlock,
herwig7p1SettingsFor7p2Block,
herwig7StableParticlesForDetectorBlock,
herwig7$tuneSettingsBlock,
configFiles = cms.vstring(),
dataLocation = cms.string('${HERWIGPATH}'),
eventHandlers = cms.string('/Herwig/EventHandlers'),
generatorModule = cms.string('/Herwig/Generators/EventGenerator'),
hw_user_settings = cms.vstring(
'set /Herwig/EventHandlers/EventHandler:LuminosityFunction:Energy $comEnergy*GeV',
$processParameters
),
parameterSets = cms.vstring(
'hw_lhe_common_settings',
'hw_lhe_powheg_settings',
'hw_7p1SettingsFor7p2',
'herwig7$tunePDF',
'herwig7$tuneAlphaS',
'herwig7$tuneMPISettings',
'herwig7StableParticlesForDetector',
'hw_user_settings'
),
repository = cms.string('${HERWIGPATH}/HerwigDefaults.rpo'),
run = cms.string('InterfaceMatchboxTest'),
runModeList = cms.untracked.string('read,run'),
)