Add 2D Binning into dc_make #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandrosov
requested changes
Jan 16, 2026
| hist_name = f"{channel}/{category}/{subp}" | ||
| if unc_name and unc_scale: | ||
| hist_name += f"_{unc_name}{unc_scale}" | ||
| hist_name += f"_{unc_name}_{unc_scale}" |
There was a problem hiding this comment.
can we directly switch to __{unc_name}__{unc_scale}?
Author
There was a problem hiding this comment.
If you are requesting that the internal (histogram) version have two _, then this is actually a request in the FLAF space. The output of data cards should be a shape with {Process}_{unc_name}{unc_scale}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.