xds-core: mark CIDR as stable #138
Open
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing the work-in-progress annotation to cidr.proto the CidrRange seems to be used in a bunch of place notably in [Envoy RBAC](https://github.com/envoyproxy/envoy/blob/09603b06b93c4f9278a096ad5beb2780eaf263fe/api/envoy/config/rbac/v3/rbac.proto#L273). Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>
adisuissa
reviewed
Jan 16, 2026
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
@kyessenov to confirm before we make it non-WIP.
kyessenov
approved these changes
Jan 16, 2026
Contributor
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
Doesn't look particular controversial so accept this as done for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing the work-in-progress annotation to cidr.proto
the CidrRange seems to be used in a bunch of place notably in Envoy RBAC.
issues for discussion: #137