new MOLT Replicator metrics page #21600
Conversation
taroface
requested review from
Jeremyyang920,
crash-overdrive,
rohan-joshi and
ryanluu12345
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
ryanluu12345
left a comment
ryanluu12345
left a comment
There was a problem hiding this comment.
The content and layout look great! I think it's a really clean doc and intuitive. I left some comments just so Shashwat can clarify a few discrepancies I noted.
Regarding the layout, I don't think you need to show the "Staging" section for MySQL, Oracle, and PG sources. Staging is really only relevant for Cockroach sources. Can probably add conditional logic there. Other than that, sections look right to me.
florence-crl
left a comment
florence-crl
left a comment
There was a problem hiding this comment.
lgtm pending suggestions
|
|
||
| - `oraclelogminer_scn_interval_size` | ||
| - Description: Size of the interval from the start SCN to the current Oracle SCN. | ||
| - Interpretation: Values larger than the [`--scnWindowSize`]({% link molt/replicator-flags.md %}#scn) flag value indicate replication lag, or that replication is idle. |
There was a problem hiding this comment.
The link is an inconsistency. The flag is --scnWindowSize, but the link goes to --scn. I do not know how to resolve this.
There was a problem hiding this comment.
@crash-overdrive @ryanluu12345 Is the proper flag name --scnWindowSize or --scn?
There was a problem hiding this comment.
From what I can tell: scnWindowSize. It should go to scnWindowSize actually
f.IntVar(&c.SCNWindowSize, "scnWindowSize", defaultSCNWindowSize, fmt.Sprintf("the max size of SCN bounds of a pull iteration from logminer, defaults to %d", defaultSCNWindowSize))
There was a problem hiding this comment.
Can you confirm this was changed recently? We have --scn all over the molt docs.
| - Interpretation: High values indicate target apply cannot keep up with incoming transactions. | ||
| - `target_apply_queue_utilization_percent` | ||
| - Description: Percentage of apply queue capacity utilization. | ||
| - Interpretation: Values above 90 percent indicate severe backpressure. Increase [`--targetApplyQueueSize`]({% link molt/replicator-flags.md %}#target-apply-queue-size) or investigate target database performance. |
There was a problem hiding this comment.
Should this flag link be displayed for MySQL and Oracle, since "This flag applies only to CockroachDB and PostgreSQL (pglogical) sources"?
There was a problem hiding this comment.
@crash-overdrive @ryanluu12345 Florence raised a really good point -- does the --targetApplyQueueSize only apply to CRDB and PG sources? If so, I need to clarify here.
Co-authored-by: Florence Morris <58752716+florence-crl@users.noreply.github.com>
crash-overdrive
left a comment
crash-overdrive
left a comment
There was a problem hiding this comment.
LGTM mod minor things!
Can we update the metric mutations_total to mutation_total and also add it to the Oracle section as oracle supports this metric as well!
Also can we move the Note for Checkpoint terminology to CRDB section only instead of all the sections? Also for some reason staging has the Note for Checkpoint terminology as well, dont know if thats intentional or not!
5 participants
DOC-15229