Skip to content

see if I can fix the example orms issue #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
angles-n-daemons wants to merge 1 commit into from
Closed

see if I can fix the example orms issue #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions testing/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ func startServerWithApplication(
func getVersionFromDB(t *testing.T, db *sql.DB) *version.Version {
t.Helper()
var crdbVersion string
if _, err := db.Exec(`SET allow_unsafe_internals=true`); err != nil {
Copy link
Contributor

@rafiss rafiss Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will cause issues when this test is executed against older versions of CRDB that don't have this setting.

i wonder if we could just change the select query below to do SHOW crdb_version instead, with some additional parsing.

root@localhost:26257/defaultdb> SELECT value FROM crdb_internal.node_build_info where field = 'Version';
         value
-----------------------
  v25.4.0-alpha.2-dev
(1 row)

Time: 1ms total (execution 1ms / network 0ms)

root@localhost:26257/defaultdb> show crdb_version;
                                         crdb_version
----------------------------------------------------------------------------------------------
  CockroachDB CCL v25.4.0-alpha.2-dev (darwin arm64, built , go1.23.12 X:nocoverageredesign)
(1 row)

Copy link
Contributor Author

@angles-n-daemons angles-n-daemons Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea, let me see if that works.

t.Fatal(err)
}
if err := db.QueryRow(
`SELECT value FROM crdb_internal.node_build_info where field = 'Version'`,
).Scan(&crdbVersion); err != nil {
Expand Down
Loading