version: update version check to use safe introspection tool

[angles-n-daemons]

Previously, we would query crdb_internal.node_build_info table to get
a cluster's version info. Starting at 26.1, we'll be blocking access to
crdb_internal tables, as they're considered part of the "unsafe
internals". To mitigate this issue before release, we'll use instead
SHOW crdb_version to collect version information about the cluster.

Fixes: #154660
Release note: none

[cockroach-teamcity]

This change is 

[Copilot]

Pull Request Overview

This PR fixes an issue with ORM examples by modifying how version strings are extracted from CockroachDB. The SHOW crdb_version query returns a fuller string (e.g., "CockroachDB v21.1.0") rather than just the version, requiring the Parse function to extract the version substring instead of requiring an exact match.

Key changes:

• Modified version.Parse() to extract version substrings from larger strings using FindString instead of requiring exact matches
• Updated SQL query in tests from crdb_internal.node_build_info to SHOW crdb_version
• Reformatted documentation comments to follow Go conventions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
version/version.go	Modified Parse function to extract version substrings, removed regex anchors, and improved doc formatting
testing/main_test.go	Changed database version query to use SHOW crdb_version instead of internal table lookup

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The version format in the documentation is incorrect. It should be "vMAJOR.MINOR.PATCH" not "vMINOR.MAJOR.PATCH". The order of MAJOR and MINOR is swapped.

Suggested change

	// "vMINOR.MAJOR.PATCH[-PRERELEASE][+METADATA]".
	// "vMAJOR.MINOR.PATCH[-PRERELEASE][+METADATA]".

[spilchen]

This seems like a good suggestion. This pre-existed your change, but since you are changing things close by, it makes sense to fix with your change.

[spilchen]

Looks good. We should probably resolve the linter error, although maybe in a separate PR as it seems unrelated to your change and a problem with the Go toolchain used in the CI. There aren't many changes to this repo (the last CI run was from Feb 2024), which is why it's only be noticed now.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

[spilchen]

This seems like a good suggestion. This pre-existed your change, but since you are changing things close by, it makes sense to fix with your change.

[angles-n-daemons]

Got it, I'll make that change, I'll also see if I can figure out how to fix the linting issue, but time box it.