Skip to content

Tolerate nullable has_notes field when fetching LeetCode submissions #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miorel merged 2 commits into from
Dec 21, 2025
Merged

Tolerate nullable has_notes field when fetching LeetCode submissions #516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6b6c85
Tolerate nullable `has_notes` field when fetching LeetCode submissions
miorel Dec 21, 2025
d8a7663
fix formatting
miorel Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion workspaces/leetcode-api/src/api/submission-list-non-graphql/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ const submissionZodType = (() => {
// eslint-disable-next-line camelcase
title_slug: slugZodType,
// eslint-disable-next-line camelcase
has_notes: z.boolean(),
has_notes: z
.boolean()
// The `has_notes` field can sometimes come back null, see for example submission 1201108107 which has an auto-generated note.
.nullable()
.transform((val) => val ?? true),
// eslint-disable-next-line camelcase
flag_type: int,
})
Expand Down
Loading