Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

Closes #1179

  • Add multi-URL aware helpers (lighthouseGroupRefs, lighthouseAuditRefs, axeGroupRefs, axeAuditRefs) that expand category refs for multi-URL configurations
  • Deprecate singular helpers (lighthouseGroupRef, lighthouseAuditRef, axeGroupRef, axeAuditRef) and category helpers (lighthouseCategories, axeCategories)
  • Remove validateUrlContext in favor of Zod schema validation via pluginUrlContextSchema
  • Implement weight averaging: when both URL weights and user-defined category ref weights are provided, the final weight is calculated as their average
  • Add unit tests for new helpers
  • Update plugin READMEs with new API examples and cross-plugin composition patterns

@hanna-skryl hanna-skryl self-assigned this Jan 8, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 8, 2026

View your CI Pipeline Execution ↗ for commit f7263a4

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 27s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 42s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-09 00:10:21 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 8, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1208

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1208

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1208

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1208

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1208

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1208

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1208

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1208

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1208

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1208

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1208

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1208

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1208

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1208

commit: f7263a4

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 09f7608 with previous commit 4d69dc3.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 36 🔴 35 ↓ −1.8
Documentation 🔴 36 🔴 37 ↑ +0.9
Code coverage 🟢 91 🟢 91 ↑ +0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 99 🟢 99
Security 🟡 51 🟡 51
Updates 🟡 78 🟡 78
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 2 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 36 🔴 35 ↓ −1.8
JSDocs coverage Documentation coverage 🔴 36 🔴 37 ↑ +0.9
Code coverage Code coverage metrics 🟢 91 🟢 91 ↑ +0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 630 ms 🟩 Root document took 410 ms ↓ −35.6 %
Lighthouse Total Blocking Time 🟥 1,780 ms 🟥 2,480 ms ↑ +39.5 %
JSDocs coverage Classes coverage 🟥 6 undocumented classes 🟥 5 undocumented classes ↓ −16.7 %
Lighthouse Time to Interactive 🟥 13.4 s 🟥 14.3 s ↑ +6.7 %
JSDocs coverage Functions coverage 🟥 587 undocumented functions 🟥 582 undocumented functions ↓ −0.9 %
JSDocs coverage Variables coverage 🟥 268 undocumented variables 🟥 267 undocumented variables ↓ −0.4 %
JSDocs coverage Types coverage 🟥 248 undocumented types 🟥 249 undocumented types ↑ +0.4 %
Code coverage Line coverage 🟨 87 % 🟨 87.1 % ↑ +0.1 %
Code coverage Function coverage 🟩 94 % 🟩 94.1 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 9.3 s 🟥 11.9 s ↑ +28.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,106 KiB 🟩 Total size was 2,107 KiB ↑ +0.1 %
Lighthouse JavaScript execution time 🟥 4.4 s 🟥 5.4 s ↑ +22.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +6.7 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 11.9 s ↑ +3.3 %
Lighthouse Max Potential First Input Delay 🟥 1,090 ms 🟥 1,330 ms ↑ +21.6 %
Lighthouse Server Backend Latencies 🟩 260 ms 🟩 230 ms ↓ −9 %
Lighthouse Speed Index 🟥 6.7 s 🟥 6.7 s ↑ +0.3 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.1 s ↑ +0.6 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↑ +1.5 %
Code coverage Branch coverage 🟨 87.3 % 🟨 87.3 % ↑ +0.1 %

658 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 09f7608 with previous commit 4d69dc3.

💼 Project plugin-axe

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 68 🟡 71 ↑ +3.1
Code coverage 🟢 93 🟢 93 ↑ +0.5

4 other categories are unchanged.

👍 2 groups improved, 👍 4 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 68 🟡 71 ↑ +3.1
Code coverage Code coverage metrics 🟢 93 🟢 93 ↑ +0.5

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Functions coverage 🟥 24 undocumented functions 🟥 21 undocumented functions ↓ −12.5 %
JSDocs coverage Variables coverage 🟥 19 undocumented variables 🟥 17 undocumented variables ↓ −10.5 %
Code coverage Line coverage 🟨 69.7 % 🟨 71.9 % ↑ +3.2 %
Code coverage Branch coverage 🟨 86.3 % 🟨 87.3 % ↑ +1.1 %

439 other audits are unchanged.

💼 Project utils

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 38 🔴 40 ↑ +1.8
Code coverage 🟢 95 🟢 95 ↓ −0.1

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 5 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 38 🔴 40 ↑ +1.8
Code coverage Code coverage metrics 🟢 95 🟢 95 ↓ −0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Classes coverage 🟥 3 undocumented classes 🟨 2 undocumented classes ↓ −33.3 %
JSDocs coverage Types coverage 🟥 47 undocumented types 🟥 48 undocumented types ↑ +2.1 %
Code coverage Branch coverage 🟩 91.9 % 🟩 91.9 % ↓ −0.1 %
JSDocs coverage Variables coverage 🟥 40 undocumented variables 🟥 41 undocumented variables ↑ +2.5 %
JSDocs coverage Functions coverage 🟥 236 undocumented functions 🟥 235 undocumented functions ↓ −0.4 %
Code coverage Line coverage 🟩 97 % 🟩 97 % ↓ −0.1 %
Code coverage Function coverage 🟩 95.6 % 🟩 95.6 % ↓ −0.1 %

437 other audits are unchanged.

💼 Project plugin-lighthouse

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 48 🔴 48 ↑ +0.9
Code coverage 🟢 99 🟢 99 ↑ +0.1

4 other categories are unchanged.

👍 2 groups improved, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 48 🔴 48 ↑ +0.9
Code coverage Code coverage metrics 🟢 99 🟢 99 ↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Functions coverage 🟥 48 undocumented functions 🟥 47 undocumented functions ↓ −2.1 %
Code coverage Line coverage 🟩 97.2 % 🟩 97 % ↓ −0.2 %
Code coverage Branch coverage 🟩 96.2 % 🟩 96.3 % ↑ +0.1 %

441 other audits are unchanged.

💼 Project models

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

All of 4 categories are unchanged.

1 audit changed without impacting score

🗃️ Groups

All of 12 groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 97.2 % 🟩 97.2 % ↑ +0.1 %

436 other audits are unchanged.


10 other projects are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review January 8, 2026 20:44
@hanna-skryl hanna-skryl requested a review from BioPhoton as a code owner January 8, 2026 20:44
@hanna-skryl hanna-skryl requested a review from matejchalk January 8, 2026 20:44
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test checks could get adjusted

@hanna-skryl hanna-skryl force-pushed the feat/multi-url-cross-plugin-refs branch from 0461ad8 to f7263a4 Compare January 8, 2026 23:53
@hanna-skryl hanna-skryl requested a review from BioPhoton January 9, 2026 00:11
return [createAggregatedCategory(groups, context)];
return [
{
slug: 'axe-a11y',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use AXE_PLUGIN_SLUG here?

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-URL aware helpers for cross-plugin composition

3 participants