-
Notifications
You must be signed in to change notification settings - Fork 15
feat: multi-URL aware helpers for cross-plugin composition #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit f7263a4
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/js-packages-plugin
@code-pushup/eslint-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 09f7608 with previous commit 4d69dc3. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
658 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 09f7608 with previous commit 4d69dc3. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 68 | 🟡 71 | |
| Code coverage | 🟢 93 | 🟢 93 |
4 other categories are unchanged.
👍 2 groups improved, 👍 4 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🟡 68 | 🟡 71 | |
| Code coverage | Code coverage metrics | 🟢 93 | 🟢 93 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Functions coverage | 🟥 24 undocumented functions | 🟥 21 undocumented functions | |
| JSDocs coverage | Variables coverage | 🟥 19 undocumented variables | 🟥 17 undocumented variables | |
| Code coverage | Line coverage | 🟨 69.7 % | 🟨 71.9 % | |
| Code coverage | Branch coverage | 🟨 86.3 % | 🟨 87.3 % |
439 other audits are unchanged.
💼 Project utils
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 38 | 🔴 40 | |
| Code coverage | 🟢 95 | 🟢 95 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 5 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🔴 38 | 🔴 40 | |
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 95 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Classes coverage | 🟥 3 undocumented classes | 🟨 2 undocumented classes | |
| JSDocs coverage | Types coverage | 🟥 47 undocumented types | 🟥 48 undocumented types | |
| Code coverage | Branch coverage | 🟩 91.9 % | 🟩 91.9 % | |
| JSDocs coverage | Variables coverage | 🟥 40 undocumented variables | 🟥 41 undocumented variables | |
| JSDocs coverage | Functions coverage | 🟥 236 undocumented functions | 🟥 235 undocumented functions | |
| Code coverage | Line coverage | 🟩 97 % | 🟩 97 % | |
| Code coverage | Function coverage | 🟩 95.6 % | 🟩 95.6 % |
437 other audits are unchanged.
💼 Project plugin-lighthouse
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 48 | 🔴 48 | |
| Code coverage | 🟢 99 | 🟢 99 |
4 other categories are unchanged.
👍 2 groups improved, 👍 2 audits improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🔴 48 | 🔴 48 | |
| Code coverage | Code coverage metrics | 🟢 99 | 🟢 99 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Functions coverage | 🟥 48 undocumented functions | 🟥 47 undocumented functions | |
| Code coverage | Line coverage | 🟩 97.2 % | 🟩 97 % | |
| Code coverage | Branch coverage | 🟩 96.2 % | 🟩 96.3 % |
441 other audits are unchanged.
💼 Project models
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
All of 4 categories are unchanged.
1 audit changed without impacting score
🗃️ Groups
All of 12 groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 97.2 % | 🟩 97.2 % |
436 other audits are unchanged.
10 other projects are unchanged.
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test checks could get adjusted
0461ad8 to
f7263a4
Compare
| return [createAggregatedCategory(groups, context)]; | ||
| return [ | ||
| { | ||
| slug: 'axe-a11y', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we use AXE_PLUGIN_SLUG here?
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comment
Closes #1179
lighthouseGroupRefs,lighthouseAuditRefs,axeGroupRefs,axeAuditRefs) that expand category refs for multi-URL configurationslighthouseGroupRef,lighthouseAuditRef,axeGroupRef,axeAuditRef) and category helpers (lighthouseCategories,axeCategories)validateUrlContextin favor of Zod schema validation viapluginUrlContextSchema