Skip to content

Conversation

@poltorak
Copy link
Collaborator

@poltorak poltorak commented Jan 9, 2026

Covers #1168

Standardize Folder Naming

Scope: Renamed mockmocks folders for consistency
Files affected: 8 files across examples and nx-plugin packages
Impact: Pure renaming with corresponding import path updates

Files changed:

examples/plugins/src/lighthouse/mock/mocks/
packages/nx-plugin/mock/mocks/
Updated import references in test files and documentation

Unify E2E Test Setup

Major consolidation of e2e test environment setup
New Centralized Utility:

Created new setupTestEnvironment() function to standardize e2e test setups.
Example transformation:

// Before: Manual setup with 15+ lines of boilerplate
const fixturesDir = path.join('e2e', 'plugin-jsdocs-e2e', 'mocks', 'fixtures');
const baseDir = path.join(E2E_ENVIRONMENTS_DIR, nxTargetProject(), TEST_OUTPUT_DIR, 'angular');
await cp(fixturesAngularDir, angularDir, { recursive: true });
// ... more setup code
// After: Single function call
const angularTestEnv = await setupTestEnvironment(['mocks', 'fixtures', 'angular'], {
  callerUrl: import.meta.url,
  git: true,
});

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin 🛠️ tooling labels Jan 9, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2026

View your CI Pipeline Execution ↗ for commit cdb82a1

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 26s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 27s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 47s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-09 12:53:56 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 9, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1209

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1209

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1209

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1209

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1209

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1209

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1209

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1209

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1209

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1209

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1209

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1209

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1209

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1209

commit: cdb82a1

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 8e11b2f with previous commit 4d69dc3.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 36 🔴 37 ↑ +0.7
Code coverage 🟢 91 🟢 91 ↓ −0.2
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 99 🟢 99
Security 🟡 51 🟡 51
Updates 🟡 78 🟡 78
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Documentation 🔴 36 🔴 36
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 1 group regressed, 👍 4 audits improved, 👎 3 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 36 🔴 37 ↑ +0.7
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.2

32 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 630 ms 🟩 Root document took 510 ms ↓ −18.9 %
Lighthouse Speed Index 🟥 6.7 s 🟨 5.5 s ↓ −18.6 %
Lighthouse Total Blocking Time 🟥 1,780 ms 🟥 2,130 ms ↑ +19.9 %
Lighthouse Time to Interactive 🟥 13.4 s 🟥 13.2 s ↓ −1.3 %
Code coverage Function coverage 🟩 94 % 🟩 93.8 % ↓ −0.3 %
Code coverage Line coverage 🟨 87 % 🟨 86.8 % ↓ −0.3 %
Code coverage Branch coverage 🟨 87.3 % 🟨 87.3 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,106 KiB 🟩 Total size was 2,116 KiB ↑ +0.5 %
Lighthouse Server Backend Latencies 🟩 260 ms 🟩 1,670 ms ↑ +553.6 %
Lighthouse Minimizes main-thread work 🟥 9.3 s 🟥 8.9 s ↓ −4.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −1.3 %
Lighthouse Max Potential First Input Delay 🟥 1,090 ms 🟥 1,240 ms ↑ +13.4 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 11.7 s ↑ +1.2 %
Lighthouse JavaScript execution time 🟥 4.4 s 🟥 4.3 s ↓ −2.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↓ −0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 221 KiB 🟥 Potential savings of 221 KiB ↑ +2.8 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↑ +4.4 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 107 KiB 🟥 Potential savings of 107 KiB ↑ +3.3 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.1 s ↑ +0.4 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 10 ms ↓ −20 %

659 other audits are unchanged.

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch 2 times, most recently from 777ce08 to 4fb2ca7 Compare January 9, 2026 12:01
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 8e11b2f with previous commit 4d69dc3.

💼 Project nx-plugin

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 89 🟡 89 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 89 🟡 89 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 76.3 % 🟨 77 % ↑ +1 %
Code coverage Line coverage 🟨 84.8 % 🟨 84.5 % ↓ −0.4 %
Code coverage Function coverage 🟩 96.4 % 🟩 96.3 % ↓ −0.1 %

445 other audits are unchanged.


13 other projects are unchanged.

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from 4fb2ca7 to cdb82a1 Compare January 9, 2026 12:37
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split mock folder renaming and setup script refactoring into 2 PR's pls.
I have some more comments on the test setup that would delay the mock renaming part.

Also i already renamed your PR to: "test: standardise mocks folder names" so I can add my feedback related to the renaming here.

@BioPhoton BioPhoton changed the title Refactor: cosmetic cleanup and changes test: standardise mocks folder names Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants