Skip to content

Conversation

@nischal-shetty2
Copy link
Contributor

reopen #1091 after adding auth as requested here #1091 (comment)

also made it more responsive

Screen.Recording.2024-09-25.at.11.07.36.PM.mov

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@nischal-shetty2
Copy link
Contributor Author

@devsargam @hkirat reopened it here. need to be reviewed!

@nischal-shetty2
Copy link
Contributor Author

@devsargam @hkirat @siinghd any updates on this? Needs to be reviewed

@devsargam
Copy link
Collaborator

includes db changes will do later

@nischal-shetty2
Copy link
Contributor Author

hey @devsargam @hkirat its been a minute🫣

@hkirat
Copy link
Contributor

hkirat commented Nov 14, 2024

This is a good one we should has out @devsargam
Dying to give out bounties in cohort 3

Copy link
Collaborator

@devsargam devsargam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@devsargam
Copy link
Collaborator

@nischal-shetty2 this took too long to review. Sorry for that I was too busy/lazy last couple of weeks.

Honestly speaking loved this pr and your code quality is over the top ✨

@devsargam
Copy link
Collaborator

Just make the changes suggested above and I think the pr is ready for review

@nischal-shetty2
Copy link
Contributor Author

@devsargam fixed them, safe to merge if no other changes required

Copy link
Collaborator

@devsargam devsargam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@devsargam devsargam merged commit 3207754 into code100x:main Nov 17, 2024
1 check failed
@devsargam
Copy link
Collaborator

Thank you sir. @hkirat might want to test out bounties starting here :p

@nischal-shetty2 nischal-shetty2 deleted the feat/bounty-submission branch November 19, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants