Skip to content

feat: embed appx video player #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hkirat merged 3 commits into from
Nov 21, 2024
Merged

feat: embed appx video player #1573

hkirat merged 3 commits into from
Nov 21, 2024

Conversation

@devsargam
Copy link
Collaborator

@devsargam devsargam commented Nov 21, 2024

Resolves #1572

@devsargam devsargam marked this pull request as draft November 21, 2024 02:28
@devsargam
Copy link
Collaborator Author

devsargam commented Nov 21, 2024 •
edited
Loading

Todos:

  • Prop drill videoId and courseId into videoplayer2.tsx
  • Test it in production
  • Add full screen button for the video player

@devsargam
Copy link
Collaborator Author

devsargam commented Nov 21, 2024

🥳
image

@devsargam devsargam requested a review from hkirat November 21, 2024 07:23
@devsargam devsargam self-assigned this Nov 21, 2024
@devsargam devsargam marked this pull request as ready for review November 21, 2024 07:23
@hkirat hkirat merged commit 315bba1 into main Nov 21, 2024
1 check failed
@devsargam devsargam deleted the feat-appx-video branch November 21, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hkirat hkirat Awaiting requested review from hkirat

Assignees

@devsargam devsargam

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Figure out APIs to open a video player that appx has on our side

4 participants

@devsargam @mrpaaradox @hkirat