Skip to content

Conversation

@HanCotterell
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🧪 PR Validation Results for #1

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
Check proper indentation passed!
Check line endings passed!


❌ 6/7 passed. Please fix the issues above and update your PR.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🧪 PR Validation Results for #1

Check PR is going to correct repo passed!
Check image path passed!
❌ Image file images/example_cow.png specified in cows/example_cow.json does not exist in the PR.
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
Check proper indentation passed!
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

Account of file size OS rounding in image max size
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🧪 PR Validation Results for #1

Check PR is going to correct repo passed!
Check image path passed!
❌ Image file images/example_cow.png specified in cows/example_cow.json does not exist in the PR.
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
Check proper indentation passed!
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🧪 PR Validation Results for #1

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
Check image file size passed!
❌ Image file name in cows/example_cow.json should be based on the cow's name. Expected: images/example_cow.png or .jpg
Check proper indentation passed!
Check line endings passed!


❌ 6/7 passed. Please fix the issues above and update your PR.

⚠️ You have 3 previous failed validation attempts. Please schedule a CSE session using your student dashboard.

Add support for JPEG image file naming convention
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🧪 PR Validation Results for #1

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
Check image file size passed!
Check file naming convention passed!
Check proper indentation passed!
Check line endings passed!


✅ All tests passed! Nice work on your PR! 🎉

@HanCotterell HanCotterell merged commit 96a1a57 into main Dec 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants